search

seguid / seguid-javascript

SEGUID v2: Checksums for Linear, Circular, Single- and Double-Stranded Biological Sequences
https://www.seguid.org
MIT License
0 stars 1 forks source link

Rename cli.js to seguid.js (or seguid if supported) #5

Closed HenrikBengtsson closed 6 months ago

HenrikBengtsson commented 6 months ago

The name cli.js is quite generic. It's better if it's clear from the CLI command what tool is called. To align it with Python, R, and soon Tcl etc., I think:

$ node seguid.js ...

would be more natural.

louisabraham commented 6 months ago

users can now run with npx seguid

HenrikBengtsson commented 6 months ago

I get

$ npx seguid
sh: 1: mycli: not found

This with:

$ npx --version
10.2.4

$ node cli.js --version
0.0.1

I installed with:

$ git log -1
commit 2e27537b401ac87e4ea9251882a9918c90d61cc3 (HEAD -> main, origin/main, origin/HEAD)
Author: louisabraham <louis.abraham@yahoo.fr>
Date:   Mon Feb 26 14:57:30 2024 +0100

    add instructions

$ npm install

up to date, audited 2 packages in 239ms

found 0 vulnerabilities
louisabraham commented 6 months ago

you need to install it globally with npm install -g

HenrikBengtsson commented 6 months ago

After 

$ git log -1
commit 31eaae3ee80bcfb6f2deb0f087141bf5ce08aa98 (HEAD -> main, origin/main, origin/HEAD)
Author: louisabraham <louis.abraham@yahoo.fr>
Date:   Mon Feb 26 15:40:30 2024 +0100

    fix script name

it works fine and it passes all make check-cli tests.

you need to install it globally with npm install -g

It looks like npm install alone is sufficient. I don't have anything in ~/.npm and npm install is all I need.