search

seguid / seguid-tcl

SEGUID v2: Checksums for Linear, Circular, Single- and Double-Stranded Biological Sequences
0 stars 0 forks source link

CLEANUP: Remove `*-IUPAC` alphabets - duplicated of `*-extended` #13

Closed HenrikBengtsson closed 3 weeks ago

HenrikBengtsson commented 3 weeks ago

Alphabets:

https://github.com/seguid/seguid-tcl/blob/40e2292ca918146ffb6a5aefda6307a2830c662e/src/seguid.tcl#L164-L166

are effectively duplicates of:

https://github.com/seguid/seguid-tcl/blob/40e2292ca918146ffb6a5aefda6307a2830c662e/src/seguid.tcl#L168-L170

The latter are part of the official SEGUID v2 specification and part of the seguid-tests test suite (https://github.com/seguid/seguid-tests/blob/main/tests-cli/70.alphabets-built-in.bats). In earlier iterations, they were indeed called *-IUPAC, but then additional symbols were added so they are no longer strictly IUPAC specifications.

/ht @louisabraham (https://github.com/seguid/seguid-tests/issues/14)

HenrikBengtsson commented 3 weeks ago

I've removed the *-IUPAC alphabets.