search

seguid / seguid-tcl

SEGUID v2: Checksums for Linear, Circular, Single- and Double-Stranded Biological Sequences
0 stars 0 forks source link

BUG: seguid --type=seguid <<< 'ACGT' should use vanilla Base64 encoding #4

Closed HenrikBengtsson closed 3 months ago

HenrikBengtsson commented 3 months ago

seguid --type=seguid ... should use vanilla Base64 encoding, because it's the original SEGUID.

 ✗ <CLI call> --type=seguid <<< 'ACGT'
   (from function `assert_output' in file test_helper/bats-assert/src/assert_output.bash, line 194,
    in test file cli.bats, line 83)
     `assert_output "seguid=IQiZThf2zKn/I1KtqStlEdsHYDQ"' failed
   cli_call: [n=1] /home/henrik/repositories/seguid/seguid-tcl/seguid

   -- output differs --
   expected : seguid=IQiZThf2zKn/I1KtqStlEdsHYDQ
   actual   : seguid=IQiZThf2zKn_I1KtqStlEdsHYDQ
   --
HenrikBengtsson commented 3 months ago

This is also why the following test fails, because --type=seguid is the default:

 ✗ <CLI call> <<< 'ACGT'
   (from function `assert_output' in file test_helper/bats-assert/src/assert_output.bash, line 194,
    in test file cli.bats, line 77)
     `assert_output "seguid=IQiZThf2zKn/I1KtqStlEdsHYDQ"' failed
   cli_call: [n=1] /home/henrik/repositories/seguid/seguid-tcl/seguid

   -- output differs --
   expected : seguid=IQiZThf2zKn/I1KtqStlEdsHYDQ
   actual   : seguid=IQiZThf2zKn_I1KtqStlEdsHYDQ
   --
HenrikBengtsson commented 3 months ago

This was fixed in commit f4b180d.