Rename material design icon, fix documentation URL

sehaas / ha_hisense_tv

Hisense TV integration for Home Assistant

MIT License

101 stars 22 forks source link

Rename material design icon, fix documentation URL #5

Closed lindsaymarkward closed 3 years ago

lindsaymarkward commented 3 years ago

Thanks for this project! I got log errors like: 2021-10-15 07:37:21 WARNING (MainThread) [frontend.js.latest.202110071] Icon mdi:television-clean was renamed to mdi:television-shimmer, please change your config, it will be removed in version 2021.12.

So, I have renamed the icon. I also got a 404 when trying to access the docs from HACS, so I have corrected this as well.

I am participating in #hacktoberfest, so I would appreciate if you could add the 'hacktoberfest-accepted' label.

Thanks 👍

lindsaymarkward commented 3 years ago

For Hacktoberfest, I believe you as the repo owner can either:

add the 'hacktoberfest 'topic to the repo, or
label the PR as 'hacktoberfest-accepted'

https://hacktoberfest.digitalocean.com/faq

Thanks.

lindsaymarkward commented 3 years ago

Hi @sehaas - would you consider this PR again now that HA 2021.11 is out? The renamed icon won't be available in the next version (.12). I just saw the message in my logs. Thanks.

sehaas commented 3 years ago

Yes I haven't forgotten this PR, but there was no reaction to my suggestion. Could you change the code to keep it backwards compatible by checking the version number?

sehaas commented 3 years ago

Thanks for the initial PR. I added your commit and extended the version check.

lindsaymarkward commented 3 years ago

Great! Glad I could help even just a tiny bit.