search

sehmaschine / django-grappelli

A jazzy skin for the Django Admin-Interface (official repository).
http://www.grappelliproject.com
Other
3.74k stars 659 forks source link

JavaScript error on item listing pages #201

Closed pedrospdc closed 12 years ago

pedrospdc commented 12 years ago

Uncaught TypeError: Object [object Object] has no method 'actions' /admin/cliente/cliente/:66 (anonymous function) /admin/cliente/cliente/:66 f.Callbacks.o jquery-1.7.2.min.js:2 f.Callbacks.p.fireWith jquery-1.7.2.min.js:2 e.extend.ready jquery-1.7.2.min.js:2 c.addEventListener.B

http://cl.ly/image/3d1Z300U2645

Django 1.4.1, fresh grappelli from stable_2.4 branch installation, Chrome 21, MACOX ML

sehmaschine commented 12 years ago

I´m having the same setup, but I´m not able to reproduce this. the file actions.js is being loaded correctly?

sehmaschine commented 12 years ago

if this problem still exists with 2.3.9 or 2.4.2, please reopen the ticket. I´m not able to reproduce this.

DrMeers commented 11 years ago

This can occur if staticfiles happens to collect/serve the contrib.admin version of actions(.min).js rather than the grappelli version.

sehmaschine commented 11 years ago

@DrMeers any idea when/why this happens?

DrMeers commented 11 years ago

it happened to me when using a custom runserver command which didn't inherit from the staticfiles version. I didn't get time to investigate why that made it serve the wrong files, since I'd have expected staticfiles_urlpatterns to still behave correctly. Using the staticfiles-overridden version of runserver corrected the issue for me

pedrospdc commented 11 years ago

I've made some research when I posted this and it seemed like Grappelli / File Browser couldn't handle custom static urls or static root directories (I can't remember which). I'm not sure if this has been fixed.

2012/11/22 Simon Meers notifications@github.com

it happened to me when using a custom runserver command which didn't inherit from the staticfiles version. I didn't get time to investigate why that made it serve the wrong files, since I'd have expected staticfiles_urlpatterns to still behave correctly. Using the staticfiles-overridden version of runserver corrected the issue for me

— Reply to this email directly or view it on GitHubhttps://github.com/sehmaschine/django-grappelli/issues/201#issuecomment-10627306.

Atenciosamente, Pedro Sampaio Palhares de Campos pedrospdc@gmail.com

sehmaschine commented 11 years ago

@pedrospdc what do you mean with "couldn´t handle"?

pedrospdc commented 11 years ago

I might be confusing this with a filebrowser issue, but it was trying to insert a /static/ url (or something like that) when my admin's static url was different (static-admin).

2012/11/22 Patrick Kranzlmueller notifications@github.com

@pedrospdc https://github.com/pedrospdc what do you mean with "couldn´t handle"?

— Reply to this email directly or view it on GitHubhttps://github.com/sehmaschine/django-grappelli/issues/201#issuecomment-10633861.

Atenciosamente, Pedro Sampaio Palhares de Campos pedrospdc@gmail.com

DrMeers commented 11 years ago

Things also can behave very stranglely when you upgrade/downgrade past https://github.com/sehmaschine/django-grappelli/commit/c7fc29f86 -- the static files change location, but collectstatic seems to not notice and does not overwrite the previously copied version. runserver behaviour may differ.

Encountering this because of a client who requires IE8 compatibility, so we needed to downgrade to 2.3.5 ... only to find that Django 1.4-compatibility only landed in 2.4.0.

sehmaschine commented 11 years ago

@DrMeers so you think that 2.3.5 is more compatible with IE8? if so, why?

chrisoates commented 11 years ago

Hi @sehmaschine, I'm working with @DrMeers on this and suggested using 2.3.5 for better IE8 compatibility (certainly from a HTML + CSS point of view) because the templates, as far as I've seen, don't use any HMTL5 elements so style correctly in IE by default and the button, header and footer backgrounds fallback to a plain color if the browser doesn't support linear-gradient in CSS.

smukkejohan commented 11 years ago

Seems this problem has do to with the collectstatic function not overwriting files correctly after upgrading Grappelli. A simple workaround is to purge your STATIC_ROOT completely and then regenerate with collectstatic.

I am running Django 1.4.2 and Grappelli 2.4.3 and run into the issue after upgrading from Grappelli 2.4.

DrMeers commented 11 years ago

@mrbichel yes, I found the same as mentioned above. @sehmaschine do you have any interest in making Grappelli 2.4.3+ IE8 compatible? We're going to have to either help to do that, or ditch Grappelli for this particular project which involves many corporate clients who are stuck on older versions of IE

sehmaschine commented 11 years ago

@DrMeers it should already be IE8 compatible (more or less). if you see any issues, please open a new ticket with details. but I´m not saying that grappelli will ever work perfectly with IE8 (that´s just not our main goal).

DrMeers commented 11 years ago

OK, the IE8 issues were outlined by @chrisoates above; I'll ask him to open a ticket with more details. The IE8 screenshots I was shown looked completely unusable.