sehmaschine / django-grappelli

A jazzy skin for the Django Admin-Interface (official repository).
http://www.grappelliproject.com
Other
3.77k stars 657 forks source link

`Select all` disappeared in v2.15.4 #985

Closed Kiougar closed 2 years ago

Kiougar commented 2 years ago

The problem

Version v2.15.4: image

Version v2.15.3: image

The cause?

I believe this was caused from #980 (specifically the ~removal of~ actions.js). Grappelli's actions.js in v2.15.3 adds an .actions method to the jquery object where Django's default actions.js adds an Actions function to the window object.


edit: minor edits for clarity

sehmaschine commented 2 years ago

FYI, actions.js has not been removed. But yes – still possible that we've missed this. We'll check asap (if you want to fix it, please use stable/2.15.x for a PR).

Kiougar commented 2 years ago

FYI, actions.js has not been removed.

Ah my bad, I misread the commits referenced in #980 👍

if you want to fix it, please use stable/2.15.x for a PR

I would like to fix it but I don't even know where to start looking.

Kiougar commented 2 years ago

I think I found something - I believe this is what causes the issue:

https://github.com/sehmaschine/django-grappelli/blob/8e0aa7402f916397278a77533b076b4055d2cc51/grappelli/compass/sass/partials/layout/_changelist.scss#L296-L300

Instead of using the above CSS rule, we need to simply add hidden to the actions.html template.

sehmaschine commented 2 years ago

I think your "fix" was not quite working. Please check mine (this works with my setup).

Kiougar commented 2 years ago

Yes you are right! Your change works 👍

Kiougar commented 2 years ago

Do we have an ETA for the release?

sehmaschine commented 2 years ago

ETA is the 21st of January.

sehmaschine commented 2 years ago

solved with 3.0.2 and 2.15.5