search

seht / volumenotification

Android app to control audio volume from notification + quick settings
https://app.hyx.net/volumenotification
Apache License 2.0
27 stars 5 forks source link

Update strings.xml #8

Closed Geogliff closed 7 years ago

seht commented 7 years ago

That's perfect. Thank you for contributing! :)

However, before I can merge, would you please change the file path (so that it does not replace the current base file), creating a new folder a level above with the language code suffix (e.g. ../values-cz/strings.xml

Thank you!

Geogliff commented 7 years ago

Is it fine now?

On Mon, Feb 6, 2017 at 6:07 PM Seht notifications@github.com wrote:

Closed #8 https://github.com/seht/volumenotification/pull/8.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/seht/volumenotification/pull/8#event-950662348, or mute the thread https://github.com/notifications/unsubscribe-auth/AYYuXtUNLgBUWYTdMID2atD6jhPUI7lNks5rZ1MygaJpZM4L3omL .

seht commented 7 years ago

You would have to change the folder and recommit it and submit a new pull request! ^^

I should have mentioned this about the folder before. Sorry my bad :)

Geogliff commented 7 years ago

Well, would you be okay with just sending the file itself then? :( I apologize, I just wanted to support your app, but as you can see, I'm pretty bad at things like GitHub, although I appreciate your try to help me and having patience with me. Thank you.

On Mon, Feb 6, 2017 at 8:00 PM Seht notifications@github.com wrote:

make you do a git pull first! :) then git add -A (before git commit) ^^

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/seht/volumenotification/pull/8#issuecomment-277778345, or mute the thread https://github.com/notifications/unsubscribe-auth/AYYuXjZQ0Q1RS-_JgeTpaq4mAvYWi9BTks5rZ23UgaJpZM4L3omL .

seht commented 7 years ago

Hey, sure thing thing. No problem at all. Just let me know what attribution you would like me to refer (like a link back to your page or such) and I'll do it for you. :) Thank you!

Geogliff commented 7 years ago

Just some reference to my nickname Geogliff would be enough. Thank you for your app, glad I could support it some way and have a nice day!

On Mon, Feb 6, 2017, 23:48 Seht notifications@github.com wrote:

Hey, sure thing thing. No problem at all. Just let me know what attribution you would like me to refer (like a link to your page or such) and I'll do it for you. :) Thank you!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/seht/volumenotification/pull/8#issuecomment-277839936, or mute the thread https://github.com/notifications/unsubscribe-auth/AYYuXkwmaRzSO6zxD_4z9sqYMjOn86wDks5rZ6NNgaJpZM4L3omL .

Geogliff commented 7 years ago

And a small suggestion - what do you think about adding a separate button for turning vibration on and off?

On Tue, Feb 7, 2017, 00:12 Geogliff geogliff@gmail.com wrote:

Just some reference to my nickname Geogliff would be enough. Thank you for your app, glad I could support it some way and have a nice day!

On Mon, Feb 6, 2017, 23:48 Seht notifications@github.com wrote:

Hey, sure thing thing. No problem at all. Just let me know what attribution you would like me to refer (like a link to your page or such) and I'll do it for you. :) Thank you!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/seht/volumenotification/pull/8#issuecomment-277839936, or mute the thread https://github.com/notifications/unsubscribe-auth/AYYuXkwmaRzSO6zxD_4z9sqYMjOn86wDks5rZ6NNgaJpZM4L3omL .