search

sehugg / dithertron

Retro 8-bit bitmap converter supporting many formats
GNU General Public License v3.0
69 stars 11 forks source link

MSX/Coleco (TMS9918A) preview vs workshop look entirely different #23

Closed robin-raymond closed 9 months ago

robin-raymond commented 9 months ago

Just making note that this routine is busted before I push my latest changes. I will try to look into this after the Zx to see what's going wrong.

coleco1 coleco2
sehugg commented 9 months ago

Hmm yeah, looks like background color.

robin-raymond commented 9 months ago

The fix is up. The transparency palette color is remapped to black (which is how this color is listed in the palette). There's no point in supporting the transparency color because the background color is available via the palette, so there's no way to get an extra color from using the transparency color with the background color somehow. And the routine has no reason to pick the background color via the transparency vs directly choosing the color via the palette. There's further no obvious way to use the transparency in some way that could be beneficial to a programmer in an automated way. The only thing I could think of is having an option where the programmer can choose "green" or whatever palette color and instead map that to transparency and use the extra bits to indicate the background color of "green". But let's leave this feature until someone has an ask and an explanation how they intend to use it (so it's not a wasted feature nobody would find a use for).