sehugg / dithertron

Retro 8-bit bitmap converter supporting many formats
GNU General Public License v3.0
75 stars 11 forks source link

Added dark and bright modes to Zx Spectrum #24

Closed robin-raymond closed 1 year ago

robin-raymond commented 1 year ago

Added dark and bright modes to Zx Spectrum

The Zx spectrum has interesting palette restrictions. Each pixel can choose from the bright part of the palette or the dark part of the palette in a cell, but no cell can choose both bright and dark at the same time.

The previous code selected from palette that was bright only and then forced a bright mode. The new logic understands the possible dark vs light choice and then chooses the appropriate dark/light choice per cell.

New options also exist to force a light or dark mode if the user has a preference for one palette or the other (for whatever reasons they might have).

Changes to the code:

Related to https://github.com/sehugg/dithertron/issues/22

robin-raymond commented 1 year ago

I have no idea why this is failing. I don't see an obvious error. Maybe it needs to be retried?

robin-raymond commented 1 year ago

I tried kicking it off again, but it just failed...

I merged and now my branch does this:

npm run build

> dithertron@1.2.1 build
> make copylibs && npm run esbuild-worker && npm run esbuild-ui

The syntax of the command is incorrect.
make: *** [Makefile:11: copylibs] Error 1

I don't want to mess with that stuff so if you can help that would be appreciated. Thanks!

robin-raymond commented 1 year ago

Ok, the make file issue for me is because I'm running under windows, not linux, but it doesn't explain the check failure.