search

sei-ec-remote / project-1-issues

Open new issues here
1 stars 2 forks source link

Centering Cards #234

Closed Jlarranaga closed 9 months ago

Jlarranaga commented 9 months ago

What's the problem you're trying to solve?

Center the game cards on the image background

Post any code you think might be relevant (one fenced block per file)

image

image

If you see an error message, post it here. If you don't, what unexpected behavior are you seeing?

No error message

What is your best guess as to the source of the problem?

either with the card class or something in my CSS

What things have you already tried to solve the problem?

google, and trial and error

Paste a link to your repository here

https://github.com/Jlarranaga/Project1-WAR

timmshinbone commented 9 months ago

Try adding a little padding on the side that is too far over and see how that reacts, maybe share a screenshot if it goes wonky

Jlarranaga commented 9 months ago

I think i got it close enough image

Jlarranaga commented 9 months ago

ok thats done

Jlarranaga commented 9 months ago

Ok now i need to center my 3 cards for war. but are they all on top of eachother? image

Jlarranaga commented 9 months ago

image

timmshinbone commented 9 months ago

Hard to say if that's the case without further review. We can take a look at this in a 1:1 right after deployment party

Jlarranaga commented 9 months ago

sounds good! Thank you!

Jlarranaga commented 9 months ago

Ok, so i decided to make an image of three cards to make life easier and now its small. I'm messing with it more but it wont get bigger. If there arent enough pixels will it stay small?

image image

timmshinbone commented 9 months ago

We resolved this by fixing the original png file to be a little bigger and to go all the way to the edge