Token factory and unlimited cap problem

Nova-Ratio commented 1 year ago

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation

It is not possible to put any cap on created tokens with token factory. It may lead to some problems in the future. If the admin address gets compromised, there might be an unlimited minting event that can harm the projects and unfortunately, the module doesn't allow to null the admin address after it's created.

Solution

No response

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

philipsu522 commented 1 year ago

Thanks @Nova-Ratio this is a good point. If you have capacity to submit a PR feel free to, otherwise we will add this to our backlog. Some things to consider:

who sets the limit
is the limit different across different denoms

LCyson commented 1 year ago

@Nova-Ratio we will keep you posted on this when we have a concrete timeline for this feature

Cordtus commented 4 months ago

You for sure can change the admin, I just created this one, minted some then changed admin to null wallet. Typically the admin would be set to a contract, which is where the limit is defined.

https://www.seiscan.app/pacific-1/txs/F561BCB0F5B19AE704DC803E211649A90F1FF09FAB27E584EFEEC6C332C5EE33

sei-protocol / sei-chain