search

sei-protocol / sei-chain

Apache License 2.0
2.67k stars 797 forks source link

No-op enumerable queries on cw721 #1677

Closed apolloshab closed 1 month ago

apolloshab commented 1 month ago

Describe your changes and provide context

No-op enumerable queries on cw721 (implementation too gas inefficient)

Testing performed to validate your change

dvli2007 commented 1 month ago

When gas limit is at the current 10M, the queries seem to work for collection sizes of at least 1000 (have not tested yet with greater collection sizes).

Would be open to taking suggestions on whether it's better to no-op the tokens and all_tokens queries, or to do something different.

dvli2007 commented 1 month ago

I discussed with a few community members about #1677. I think since gas cap for queries is back at 10M, it may be worthwhile to keep the tokens and all_tokens queries as they are currently in the pointer contract for now.

Let's close this PR then, and we can revisit if gas caps change.