sei-protocol / sei-chain

Apache License 2.0
2.67k stars 797 forks source link

[EVM] Avoid approvals with native pointers #1687

Closed stevenlanders closed 1 month ago

stevenlanders commented 1 month ago

Describe your changes and provide context

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 60.66%. Comparing base (c725b57) to head (4fc1abf).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1687/graphs/tree.svg?width=650&height=150&src=pr&token=DG7ZZJ3PVV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) ```diff @@ Coverage Diff @@ ## main #1687 +/- ## ========================================== - Coverage 60.79% 60.66% -0.13% ========================================== Files 368 368 Lines 26848 26864 +16 ========================================== - Hits 16321 16298 -23 - Misses 9414 9456 +42 + Partials 1113 1110 -3 ``` | [Files](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1687?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) | Coverage Δ | | |---|---|---| | [x/evm/artifacts/native/artifacts.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1687?src=pr&el=tree&filepath=x%2Fevm%2Fartifacts%2Fnative%2Fartifacts.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0vYXJ0aWZhY3RzL25hdGl2ZS9hcnRpZmFjdHMuZ28=) | `10.41% <ø> (ø)` | | | [x/evm/artifacts/native/native.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1687?src=pr&el=tree&filepath=x%2Fevm%2Fartifacts%2Fnative%2Fnative.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0vYXJ0aWZhY3RzL25hdGl2ZS9uYXRpdmUuZ28=) | `0.00% <0.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1687/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)
stevenlanders commented 1 month ago

looks good! in the call, we discussed potentially updating the symbol/name to pull from the token itself - is that something we still wanna do?

I initially updated it, but then looked further at the deployment process, and there's some validation to prevent deployment if these metadata items do not exist but still allow a governance proposal registration (scenario is a native coin without metadata, which allows one to specify metadata during this deploy)

stevenlanders commented 1 month ago

Closing for now, we believe approvals on EVM side only are okay because they enable Uniswap and other EVM-friendly situations.