Closed stevenlanders closed 1 month ago
Attention: Patch coverage is 0%
with 34 lines
in your changes are missing coverage. Please review.
Project coverage is 60.66%. Comparing base (
c725b57
) to head (4fc1abf
).
looks good! in the call, we discussed potentially updating the symbol/name to pull from the token itself - is that something we still wanna do?
I initially updated it, but then looked further at the deployment process, and there's some validation to prevent deployment if these metadata items do not exist but still allow a governance proposal registration (scenario is a native coin without metadata, which allows one to specify metadata during this deploy)
Closing for now, we believe approvals on EVM side only are okay because they enable Uniswap and other EVM-friendly situations.
Describe your changes and provide context
Testing performed to validate your change