search

sei-protocol / sei-chain

Apache License 2.0
2.7k stars 805 forks source link

remove serialize/deserialize for accesslist #1701

Open codchen opened 4 months ago

codchen commented 4 months ago

Describe your changes and provide context

Because accessLists are only used within the lifespan of its transaction, there is no need to serialize/deserialize it as it won't be transmitted over wire nor written to disk. This would improve performance for transactions that make heavy usage of accesslists

Testing performed to validate your change

no behavioral change so existing unit tests should cover

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 60.52632% with 15 lines in your changes missing coverage. Please review.

Project coverage is 60.78%. Comparing base (a0e7266) to head (26c91e6).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1701/graphs/tree.svg?width=650&height=150&src=pr&token=DG7ZZJ3PVV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) ```diff @@ Coverage Diff @@ ## main #1701 +/- ## ========================================== - Coverage 60.87% 60.78% -0.10% ========================================== Files 370 370 Lines 27436 27447 +11 ========================================== - Hits 16702 16683 -19 - Misses 9592 9622 +30 Partials 1142 1142 ``` | [Files](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1701?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) | Coverage Δ | | |---|---|---| | [x/evm/keeper/msg\_server.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1701?src=pr&el=tree&filepath=x%2Fevm%2Fkeeper%2Fmsg_server.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0va2VlcGVyL21zZ19zZXJ2ZXIuZ28=) | `76.53% <100.00%> (+0.08%)` | :arrow_up: | | [x/evm/state/statedb.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1701?src=pr&el=tree&filepath=x%2Fevm%2Fstate%2Fstatedb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0vc3RhdGUvc3RhdGVkYi5nbw==) | `47.22% <16.66%> (-1.80%)` | :arrow_down: | | [x/evm/state/accesslist.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1701?src=pr&el=tree&filepath=x%2Fevm%2Fstate%2Faccesslist.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0vc3RhdGUvYWNjZXNzbGlzdC5nbw==) | `86.84% <67.74%> (-7.61%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1701/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)