sei-protocol / sei-chain

Apache License 2.0
2.67k stars 797 forks source link

[EVM] associate via bytes conversion #1706

Open stevenlanders opened 1 month ago

stevenlanders commented 1 month ago

Describe your changes and provide context

Going forward, we will stop supporting address association based on pubkey derivation, but use direct casting for all accounts who haven't already established pubkey-based association. Existing pubkey-based association will still be respected. Namely the following changes are made:

Testing performed to validate your change

unit tests

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 76.66667% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 60.90%. Comparing base (1702e4e) to head (cbef8fc).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706/graphs/tree.svg?width=650&height=150&src=pr&token=DG7ZZJ3PVV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) ```diff @@ Coverage Diff @@ ## main #1706 +/- ## ========================================== + Coverage 60.69% 60.90% +0.20% ========================================== Files 370 368 -2 Lines 27279 26930 -349 ========================================== - Hits 16558 16402 -156 + Misses 9585 9433 -152 + Partials 1136 1095 -41 ``` | [Files](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) | Coverage Δ | | |---|---|---| | [aclmapping/evm/mappings.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&filepath=aclmapping%2Fevm%2Fmappings.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-YWNsbWFwcGluZy9ldm0vbWFwcGluZ3MuZ28=) | `92.17% <100.00%> (+3.09%)` | :arrow_up: | | [app/antedecorators/gasless.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&filepath=app%2Fantedecorators%2Fgasless.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-YXBwL2FudGVkZWNvcmF0b3JzL2dhc2xlc3MuZ28=) | `83.45% <ø> (+5.28%)` | :arrow_up: | | [evmrpc/association.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&filepath=evmrpc%2Fassociation.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-ZXZtcnBjL2Fzc29jaWF0aW9uLmdv) | `58.33% <100.00%> (+27.49%)` | :arrow_up: | | [evmrpc/server.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&filepath=evmrpc%2Fserver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-ZXZtcnBjL3NlcnZlci5nbw==) | `86.61% <100.00%> (ø)` | | | [precompiles/bank/bank.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&filepath=precompiles%2Fbank%2Fbank.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-cHJlY29tcGlsZXMvYmFuay9iYW5rLmdv) | `58.09% <100.00%> (+1.41%)` | :arrow_up: | | [precompiles/distribution/distribution.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&filepath=precompiles%2Fdistribution%2Fdistribution.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-cHJlY29tcGlsZXMvZGlzdHJpYnV0aW9uL2Rpc3RyaWJ1dGlvbi5nbw==) | `52.47% <100.00%> (+3.82%)` | :arrow_up: | | [precompiles/gov/gov.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&filepath=precompiles%2Fgov%2Fgov.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-cHJlY29tcGlsZXMvZ292L2dvdi5nbw==) | `55.78% <100.00%> (+3.31%)` | :arrow_up: | | [precompiles/staking/staking.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&filepath=precompiles%2Fstaking%2Fstaking.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-cHJlY29tcGlsZXMvc3Rha2luZy9zdGFraW5nLmdv) | `67.69% <100.00%> (+4.38%)` | :arrow_up: | | [precompiles/wasmd/wasmd.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&filepath=precompiles%2Fwasmd%2Fwasmd.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-cHJlY29tcGlsZXMvd2FzbWQvd2FzbWQuZ28=) | `63.80% <100.00%> (+1.93%)` | :arrow_up: | | [x/evm/ante/error.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree&filepath=x%2Fevm%2Fante%2Ferror.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0vYW50ZS9lcnJvci5nbw==) | `100.00% <ø> (ø)` | | | ... and [21 more](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1706/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)