sei-protocol / sei-chain

Apache License 2.0
2.67k stars 797 forks source link

Add gov proposal v2 for native pointer #1711

Closed codchen closed 4 weeks ago

codchen commented 1 month ago

Describe your changes and provide context

Add a new gov proposal type to register pointer for native tokens by providing only metadata instead of a deployed contract address, to make sure all pointers are running the same version.

Some notes:

Testing performed to validate your change

unit test

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 63.63636% with 36 lines in your changes missing coverage. Please review.

Project coverage is 60.43%. Comparing base (3862f3b) to head (0ae7350).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1711/graphs/tree.svg?width=650&height=150&src=pr&token=DG7ZZJ3PVV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1711?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) ```diff @@ Coverage Diff @@ ## main #1711 +/- ## ========================================== - Coverage 60.54% 60.43% -0.12% ========================================== Files 370 370 Lines 27367 27407 +40 ========================================== - Hits 16570 16564 -6 - Misses 9673 9713 +40 - Partials 1124 1130 +6 ``` | [Files](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1711?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) | Coverage Δ | | |---|---|---| | [x/evm/types/codec.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1711?src=pr&el=tree&filepath=x%2Fevm%2Ftypes%2Fcodec.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0vdHlwZXMvY29kZWMuZ28=) | `52.00% <100.00%> (+0.64%)` | :arrow_up: | | [x/evm/types/gov.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1711?src=pr&el=tree&filepath=x%2Fevm%2Ftypes%2Fgov.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0vdHlwZXMvZ292Lmdv) | `22.28% <100.00%> (+12.49%)` | :arrow_up: | | [x/evm/handler.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1711?src=pr&el=tree&filepath=x%2Fevm%2Fhandler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0vaGFuZGxlci5nbw==) | `10.25% <0.00%> (-0.56%)` | :arrow_down: | | [x/evm/gov.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1711?src=pr&el=tree&filepath=x%2Fevm%2Fgov.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0vZ292Lmdv) | `49.36% <53.42%> (-50.64%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1711/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)
0xskinnyg commented 2 weeks ago

If we have set-denom-metadata on the Cosmos side why can't we have a similar command for the EVM pointer instead of having to submit a proposal?

This is hard for small projects as you have to deposit 3,500 SEI and have around 2bn votes for the proposal to go through.

From my personal experience, I've been trying to get help to make my proposal go through for the last 2 weeks and it has been unsuccessful so far.