sei-protocol / sei-chain

Apache License 2.0
2.7k stars 805 forks source link

Register evm (and other missing) module grpc routes endpoints #1717

Closed dssei closed 3 months ago

dssei commented 3 months ago

Describe your changes and provide context

At the moment our evm (REST) endpoints under sei-protocol/seichain/evm/evm_address are not registered and are returning the following error:

{
    "code": 12,
    "message": "Not Implemented",
    "details": []
}

E.g.

https://rest.atlantic-2.seinetwork.io/sei-protocol/seichain/evm/evm_address?sei_address=sei1cthlgsndtv9e40pysuuzrhj9pusq4knq6vr9gl

That's because we do not register routes in the module. Another example is epoch module.

This PR adds missing registration.

Testing performed to validate your change

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.79%. Comparing base (4f2c02d) to head (e8c3644). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1717/graphs/tree.svg?width=650&height=150&src=pr&token=DG7ZZJ3PVV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) ```diff @@ Coverage Diff @@ ## main #1717 +/- ## ========================================== + Coverage 60.74% 60.79% +0.05% ========================================== Files 370 370 Lines 27433 27435 +2 ========================================== + Hits 16665 16680 +15 + Misses 9627 9615 -12 + Partials 1141 1140 -1 ``` | [Files](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1717?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) | Coverage Δ | | |---|---|---| | [x/epoch/module.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1717?src=pr&el=tree&filepath=x%2Fepoch%2Fmodule.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9lcG9jaC9tb2R1bGUuZ28=) | `91.56% <100.00%> (+1.32%)` | :arrow_up: | | [x/evm/module.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1717?src=pr&el=tree&filepath=x%2Fevm%2Fmodule.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0vbW9kdWxlLmdv) | `55.88% <100.00%> (+1.06%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1717/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)