search

sei-protocol / sei-chain

Apache License 2.0
2.67k stars 797 forks source link

Handle VM error code properly #1726

Closed codchen closed 3 weeks ago

codchen commented 3 weeks ago

Describe your changes and provide context

Within EVM module we still want to treat the newly added VM error code as "successful" on the tx-level, in the sense that we don't want to perform a tx-level rollback.

Testing performed to validate your change

unit tests

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.83%. Comparing base (79318fb) to head (50b6261).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1726/graphs/tree.svg?width=650&height=150&src=pr&token=DG7ZZJ3PVV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) ```diff @@ Coverage Diff @@ ## BumpSeiCosmos #1726 +/- ## ================================================= + Coverage 60.81% 60.83% +0.02% ================================================= Files 370 370 Lines 27436 27436 ================================================= + Hits 16685 16692 +7 + Misses 9609 9602 -7 Partials 1142 1142 ``` | [Files](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1726?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) | Coverage Δ | | |---|---|---| | [x/evm/keeper/keeper.go](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1726?src=pr&el=tree&filepath=x%2Fevm%2Fkeeper%2Fkeeper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-eC9ldm0va2VlcGVyL2tlZXBlci5nbw==) | `49.46% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/sei-protocol/sei-chain/pull/1726/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)