search

sei-protocol / sei-js

SeiJS is a monorepo that contains multiple NPM libraries for writing applications that interact with the Sei network.
44 stars 38 forks source link

Fix: @sei-js/cosmjs importing SignDoc type and using it as object #156

Closed codebycarson closed 6 months ago

codebycarson commented 7 months ago

This mistake was made internally as well, the way types are exported from @sei-js/proto is confusing, but this PR fixes the issue.

changeset-bot[bot] commented 7 months ago

🦋 Changeset detected

Latest commit: c3431d78cc147989bd2bc4519341479cb1ba0dda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @sei-js/cosmjs | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.37%. Comparing base (1e2d6fd) to head (c3431d7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #156 +/- ## ======================================= Coverage 84.37% 84.37% ======================================= Files 17 17 Lines 160 160 Branches 23 23 ======================================= Hits 135 135 Misses 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.