search

sei-protocol / sei-js

SeiJS is a monorepo that contains multiple NPM libraries for writing applications that interact with the Sei network.
44 stars 38 forks source link

Added unit tests to /core and /react #92

Closed codebycarson closed 1 year ago

codebycarson commented 1 year ago

This Pull Request primarily focuses on bolstering the testing environment and improving the code quality within the core and react packages. By introducing new testing utilities and enhancing the test coverage, we aim to ensure robustness and ease of maintenance. Moreover, some adjustments in the GitHub workflow configurations and refactoring within certain components and hooks have been carried out to align with the updated testing setup.

Detailed changes include:

  1. New testing utilities introduced in both core and react packages to bolster test setup.
  2. Enhanced testing coverage with additional test cases across various modules.
  3. GitHub workflow configurations updated in checks.yml, coverage.yml, and release.yml to streamline the CI/CD process.
  4. Jest and Babel configurations adjusted within packages/core and packages/react to align with testing enhancements.
  5. WalletConnectButton and WalletSelectModal components in the react package have been modified for better testability.
changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 86b6823b7bc1d9a9c43e06086b48263524973c38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov-commenter commented 1 year ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

codebycarson commented 1 year ago

is the codecov github action enabled in this PR? where can i find the coverage report for this PR

Here is the action that ran for this.

https://github.com/sei-protocol/sei-js/actions/runs/6478880820/job/17591369564

As the codecov bot commented above this won't show in the PR's until I merge this the first time

"Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment."