search

sei-protocol / sei-tendermint

Tendermint fork with ABCI++ support, bug fixes, and custom features
Other
39 stars 36 forks source link

Broadcast result should also pass log #201

Closed yzang2019 closed 10 months ago

yzang2019 commented 10 months ago

Describe your changes and provide context

Problem: Current Tendermint is not passing log into the broadcast result, this would cause some information missing when trying to debug broadcast failures.

Testing performed to validate your change

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (da59b8d) 57.94% compared to head (017aba2) 57.92%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/201/graphs/tree.svg?width=650&height=150&src=pr&token=VYIWMMGYMP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) ```diff @@ Coverage Diff @@ ## main #201 +/- ## ========================================== - Coverage 57.94% 57.92% -0.02% ========================================== Files 249 249 Lines 33915 33916 +1 ========================================== - Hits 19651 19645 -6 - Misses 12692 12705 +13 + Partials 1572 1566 -6 ``` | [Files](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) | Coverage Δ | | |---|---|---| | [internal/rpc/core/mempool.go](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-aW50ZXJuYWwvcnBjL2NvcmUvbWVtcG9vbC5nbw==) | `0.00% <0.00%> (ø)` | | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/201/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)