search

sei-protocol / sei-tendermint

Tendermint fork with ABCI++ support, bug fixes, and custom features
Other
39 stars 36 forks source link

Add metrics for mempool change #219

Closed yzang2019 closed 5 months ago

yzang2019 commented 8 months ago

Describe your changes and provide context

This PR added two new metrics for tendermint mempool, which tracks number of txs inserted and removed from mempool

Testing performed to validate your change

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 57.88%. Comparing base (3affbcf) to head (7c60726).

:exclamation: Current head 7c60726 differs from pull request most recent head 39787ff

Please upload reports for the commit 39787ff to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/219/graphs/tree.svg?width=650&height=150&src=pr&token=VYIWMMGYMP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) ```diff @@ Coverage Diff @@ ## main #219 +/- ## ========================================== - Coverage 58.19% 57.88% -0.32% ========================================== Files 249 249 Lines 34445 34022 -423 ========================================== - Hits 20045 19693 -352 + Misses 12814 12754 -60 + Partials 1586 1575 -11 ``` | [Files](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/219?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol) | Coverage Δ | | |---|---|---| | [internal/mempool/mempool.go](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/219?src=pr&el=tree&filepath=internal%2Fmempool%2Fmempool.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-aW50ZXJuYWwvbWVtcG9vbC9tZW1wb29sLmdv) | `70.16% <100.00%> (-2.72%)` | :arrow_down: | | [internal/mempool/metrics.gen.go](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/219?src=pr&el=tree&filepath=internal%2Fmempool%2Fmetrics.gen.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol#diff-aW50ZXJuYWwvbWVtcG9vbC9tZXRyaWNzLmdlbi5nbw==) | `16.17% <14.28%> (+0.32%)` | :arrow_up: | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/sei-protocol/sei-tendermint/pull/219/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sei-protocol)