Patch regex to support new known cases

seia-soto / snowpack-plugin-import-map

A snowpack plugin that maps your imports to Skypack or other sources.

https://zhoukekestar.github.io/notes/2020/06/08/micro-frontends.html

MIT License

39 stars 3 forks source link

Patch regex to support new known cases #9

Closed seia-soto closed 3 years ago

seia-soto commented 3 years ago

This PR resolves the problem which caused by adding 2 slashes in module-name in #8.

Updated test file:
- Invalid variable from my previous PR
- Added new test case
Updated README: This includes some warning missed from previous PR because the PR process ended too fast
Updated regular expression

zhoukekestar commented 3 years ago

Hi, Seia-Soto. Thanks for your PR angin. I'd like to transfer this repo to you, but I got error: "Seia-Soto/snowpack-plugin-import-map already exists". I need your cooperation that delete your forked repo first so that I can do transfer.

And the same time, I need your npm account to be added, so that you can publish this package.

zhoukekestar commented 3 years ago

All PR is merged so you can delete your old repo safely.

seia-soto commented 3 years ago

I just deleted my fork successfully, but I think this is your work and can maintain in current permission, so moving whole project is still optional for you.

You can use my credentials to transfer:

GitHub: @Seia-Soto NPM: seia

zhoukekestar commented 3 years ago

[x] Transfer repo is requested.
[x] Npm owner is added. Everything is done. Thanks for your maintain. 😀

seia-soto commented 3 years ago

No problem. Also, thank you for creating this project. Your works helped me a lot.