Colorful Secrets - Githubissues

seibert-media / teamvault

Keep your company's passwords behind the firewall

Other

40 stars 12 forks source link

Colorful Secrets #168

Closed NilsGke closed 1 month ago

NilsGke commented 2 months ago

(did a git oopsie😐 - old PR: #167 )

recap:

I like how secrets are colored in 1password and implemented it for Teamvault
it differentiates between lowercase, uppercase, numbers and symbols (everything that is not cought in the previous categories)
Using innerHTML turned out to be an easy code injection -> now adding elements programmatically
colors can be configured in secrets.scss

up for discussion:

I replaced the input with a div, to allow use of spans to color the secret - Does the input have any advantages over a div?
colors ok?

dracador commented 1 month ago

Hey, thank you for this! I'm not 100% sure if we want the uppercase and lowercase letters to be different colors, but I'll just try to get some feedback from others while dogfooding. Otherwise LGTM :+1: