search

seiflotfy / cuckoofilter

Cuckoo Filter: Practically Better Than Bloom
MIT License
1.11k stars 107 forks source link

Great work! Can you use xxh3? #39

Open hiqsociety opened 3 years ago

hiqsociety commented 3 years ago

https://github.com/seiflotfy/cuckoofilter/blob/master/util.go

This one instead of metrohash. https://github.com/zeebo/xxh3

Will wait for your update. It's great piece of software.

  1. By the way, what's the recommended size of NewFilter(1000000) <- what do you suggest? and roughly how much memory is taken by increasing this value?

Sorry I'm a bit dense on this cuckoo filter thing. Can you suggest a value for NewFilter?

I would like to perform matching against 16mil ip addresses.

  1. What is a better use case for panmari 16bit cuckoo filter u mentioned? wouldnt everyone want a lower false positive match?
MeteorsLiu commented 1 year ago

LGTM.

MeteorsLiu commented 1 year ago

Well, i create a new fork of it.

It uses XXH3 and 16 bits fingerprint(done by panmari)

https://github.com/InteractivePlus/cuckoofilter

Maybe someone could try about this?

More "reliable" and faster looking up / inserting.

But i am not sure about that will work well, even though it passed all tests.

However, it still requires testing.