search

seiginonakama / BlockCanaryEx

make performance bottleneck detection easily when app blocked
Apache License 2.0
2.17k stars 233 forks source link

Remove supportsRtl and allowBackup from manifest #5

Closed PaulWoitaschek closed 7 years ago

PaulWoitaschek commented 7 years ago

When I want to setup the library I get a build error:

Error:
    Attribute application@allowBackup value=(false) from AndroidManifest.xml:40:9-36
    is also present at [com.letv.sarrsdesktop:BlockCanaryExJRT:0.9.5.2] AndroidManifest.xml:12:9-35 value=(true).
    Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:38:5-157:19 to override.

Error:
    Attribute application@supportsRtl value=(false) from AndroidManifest.xml:44:9-36
    is also present at [com.letv.sarrsdesktop:BlockCanaryExJRT:0.9.5.2] AndroidManifest.xml:13:9-35 value=(true).
    Suggestion: add 'tools:replace="android:supportsRtl"' to <application> element at AndroidManifest.xml:38:5-157:19 to override.

I think a library should not specify these attributes.

seiginonakama commented 7 years ago

you are right, the pull request be merged just now, you are welcome.

seiginonakama commented 7 years ago

the issue fixed in 0.9.5.3