search

seiichiro0185 / sailotp

A Sailfish Google Authenticator Implementation
https://www.seiichiro0185.org/sailfish:apps:sailotp:start
Other
49 stars 25 forks source link

SailOTP doesn't recognize a QR code for github #49

Open ddobrev opened 3 years ago

ddobrev commented 3 years ago

Regardless of the size of the QR code and the mode I put the scanner in by clicking the preview, nothing happens. The built-in camera application in Sailfish, on the contrary, recognizes it almost immediately even when the image is small. So does Foil Auth. I also copied the secret key these gave me and then added it to SailOTP which was then able to work and generate correct codes. So in general it works, it just failed to recognize my QR code. My Sailfish is at version 4.0.1.48, SailOTP is latest.

seiichiro0185 commented 3 years ago

Hi,

well yes, the QR codereader in SailOTP is a dirty hack from the early days of SailfishOS, which also means it's not very good. Unfortunately I didn't have the time so far to do a rewrite of it, or investigate if or how it is possible to use the native one from the Camera (open SailOTP if TOPT / HOTP URL is found or something like this).

I'll take a look at this when I find the time, or gladly accept pull requests for a fixes or a rewritten QR codereader part in the meantime.

My preferred solution would be to use the native one from the SFOS Camera, to not reinvent the wheel for something thats already there in the Base OS. Not sure if thats possible at the moment (and allowed in Harbour Apps)