search

seime / openhab-esphome

ESPHome native API implementation for openHAB binding
MIT License
22 stars 4 forks source link

Remove temporary service naming scheme #3

Open jimtng opened 10 months ago

jimtng commented 10 months ago

What was the reason of adding this? Is it OK to take this out?

seime commented 10 months ago

@jimtng this is a workaround for https://github.com/openhab/openhab-core/issues/3753

jimtng commented 10 months ago

IMO it would still be better to remove the additional name and solve the linked issue some other way, because people who use UI would probably just accept the suggested naming anyway, thus back to the original problem.

I don't use UI discovery, so I'm not personally too invested in this. I only used it to try things out and noticed this. Feel free to close this if you think the naming should remain.

seime commented 10 months ago

Unfortunately the discovery runs in the background anyhow, and unless you are using thing files yes you will have trouble if you do not remove this part.

Personally I use files so I am not affected, but it was reported here as #1 . Would prefer to have this fixed in core, but the discussion with the maintainers stalled

amandel commented 7 months ago

What about adding a additional configuration option do store either the discovered dns name or a manually entered dns/ip? This would allow the manual setting to survive.