seishun / node-steam

Interface directly with Steam servers from Node.js
MIT License
1k stars 180 forks source link

Is this project still maintained? #386

Closed PanicIsReal closed 7 years ago

PanicIsReal commented 7 years ago

Everything still works fine, but haven't seen a commit since last year. Just wondering if this project is still maintained or if @seishun has moved on. Thanks!

scholtzm commented 7 years ago

The only thing I can think of that should be updated are the outdated bundled protobuf definitions. There have been quite a few updates since Dec 26th, 2015:

https://github.com/SteamRE/SteamKit/commits/master/Resources/Protobufs

There have been some SteamLanguage changes as well:

https://github.com/SteamRE/SteamKit/commits/master/Resources/SteamLanguage

seishun commented 7 years ago

@Gacnt

Well, there isn't much to commit when everything works fine, is there? ;)

@scholtzm

Resources are part of the npm package, not this repo. The package just contains whatever SteamRE had at the moment of publishing. I'd have to bump the version and re-publish to update them. Is there any node-steam functionality that would benefit from updated resources?

Either way, you can always update them manually by running npm install inside the module directory.

PanicIsReal commented 7 years ago

Nope not complaining at all, works fine for what I need it for, just didn't want to build something based around it then find out next big steam update you no longer have any interest in maintaining it them I'm up the river without a paddle

scholtzm commented 7 years ago

@seishun Yep, I know. But updating the package once every 3-6 months wouldn't hurt anyone and users would be provided with fresh resources.

I know it's possible to do manual update on user's end but running npm install in dependency folder to update it's resources is fairly clumsy and non-idiomatic for npm packages. Also, it's not even mentioned in the README.

seishun commented 7 years ago

But updating the package once every 3-6 months wouldn't hurt anyone and users would be provided with fresh resources.

Except it would be confusing to see a bunch of subsequent "version bump" commits in the commit log. And needing latest protobufs seems to be a rare case.

Also, it's not even mentioned in the README.

Right, I suppose the README could mention that the git installation step can be done at any time even if it's installed from npm. Do you have any suggestions on how it could be worded?

ghost commented 7 years ago

How come this is not on npm anymore?

PanicIsReal commented 7 years ago

It is, https://www.npmjs.com/package/steam On Tue, Dec 6, 2016 at 7:13 AM dgdiablogist notifications@github.com wrote:

How come this is not on npm anymore?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seishun/node-steam/issues/386#issuecomment-265159126, or mute the thread https://github.com/notifications/unsubscribe-auth/ADTlMoAGjA0DFna9V6GlQL0qhEDfsuHoks5rFW1xgaJpZM4KoEPs .

PanicIsReal commented 7 years ago

@scholtzm @seishun Just wondering if this is still maintained again, been 2 years since last commit.

seishun commented 7 years ago

Yes, it is.