search

seismo-live / seismo_live

Live Jupyter Notebooks for Seismology
http://seismo-live.org
78 stars 73 forks source link

add 3 NB 2 signal processing #10

Closed stefdonner closed 7 years ago

stefdonner commented 7 years ago

Hey there, I decided for "Signal Processing" as main headline for these 3 NBs and created a new directory for that topic. My opinion: in the "General Seismology" directory things like magnitude estimation, focal mechanisms and such stuff shall be included but no data processing. If you don't agree go ahead as you want with 'my' NBs. Cheers Stefanie

krischer commented 7 years ago

Cool thanks :-) This looks really great especially the extensive descriptions! Once this is ready I'll add it to the index title page.

A couple of comments (I cannot do it inline as the notebook files are too big for Github's interface to work):

  1. Can you please replace all occurrences of %pylab inline with %matplotlib inline. pylab does no longer really work with all new and upcoming matplotlib versions and has been deprecated I think.
  2. Instead of adding the answers to the solutions at the bottom: Can you please copy the notebooks and add _solutions to their name? This would be consistent with how its done all over seismo-live.
  3. Can you please rerun and save the notebooks with Python 3?

Once you are done, just push to the same branch once again and it will be updated.

stefdonner commented 7 years ago

Better? Shame on me that I was still working with python 2 ...

krischer commented 7 years ago

Beautiful :-) Thanks also for the consistent title case 👍

It will go live the next time I update seismo-live - I cannot do it without turning it off for half an hour an currently there are always some people using it.

heinerigel commented 7 years ago

I agree that signal processing should be an own category

looking forward to seeingthem live!

wow you are PUSHING!

Cheers Heiner

Am 22.11.2016 um 15:42 schrieb Lion Krischer:

Cool thanks :-) This looks really great especially the extensive descriptions! Once this is ready I'll add it to the index title page.

A couple of comments (I cannot do it inline as the notebook files are too big for Github's interface to work):

  1. Can you please replace all occurrences of |%pylab inline| with |%matplotlib inline|. |pylab| does no longer really work with all new and upcoming matplotlib versions and has been deprecated I think.
  2. Instead of adding the answers to the solutions at the bottom: Can you please copy the notebooks and add |_solutions| to their name? This would be consistent with how its done all over seismo-live.
  3. Can you please rerun and save the notebooks with Python 3?

Once you are done, just push to the same branch once again and it will be updated.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/krischer/seismo_live/pull/10#issuecomment-262258072, or mute the thread https://github.com/notifications/unsubscribe-auth/AAT0HQNMpB0Da_omApYM12cs_PeF2ueKks5rAv9BgaJpZM4K5fuH.

Prof. Heiner Igel Department of Earth and Environmental Sciences Ludwig-Maximilians-University Theresienstr. 41 80333 Munich - Germany phone: +49 89 2180 4204 www.geophysik.uni-muenchen.de/Members/igel

Computational Seismology: A Practical Introduction, Oxford University Press

http://www.oup.com/localecatalogue/cls_academic/?i=9780198717416

megies commented 7 years ago

currently there are always some people using it.

:tada:

I agree that signal processing should be an own category

:+1:

krischer commented 7 years ago

All done. The signal processing notebooks are now also part of the overview, I fixed some import problems and made some stylistic changes (I mainly limited the maximum line length so that seismo-live looks reasonable on smallish screens).

Thanks again! These notebooks are really cool - I'll let you know once they go online so you can go check them out.

krischer commented 7 years ago

They are now live. Let me know if something does not work as expected!