Should add a json checker to CI

seismo-live / seismo_live

Live Jupyter Notebooks for Seismology

http://seismo-live.org

79 stars 74 forks source link

Should add a json checker to CI #24

Open megies opened 6 years ago

megies commented 6 years ago

Would be good if CI could check for valid json (or even validating against a Jupyter notebook schema), for plain text changes to notebooks like in #23. Currently CI will be green even if there are .ipynb files that are no valid json.

krischer commented 6 years ago

Currenty there is no CI 🙈

There is a very rudimentary test routine in the root directory but it takes too long to execute to run in CI so I do agree that some basic linters would help a lot!