search

seismology / mc_kernel

Calculate seismic sensitivity kernels using Axisem
GNU General Public License v3.0
24 stars 8 forks source link

Normalization term initialized temperamentally #68

Open EoghanTotten opened 5 years ago

EoghanTotten commented 5 years ago

https://github.com/seismology/mc_kernel/blob/master/src/kernel.f90#L435-L460

I noticed when compiling mc_kernel on my local machine, the following warning for kernel.f90:

'Extension: Unary operator following arithmetic operator (use parentheses) at (1) Warning: ‘normalization_term’ may be used uninitialized in this function [-Wmaybe-uninitialized]'.

By placing brackets around each of the four -1.d0 terms in the above lines (e.g. calc_misfit_kernel(itrace) = this%integrate_parseval( timeseries_cut, this%seis_velo_cut_fd) &

sstaehler commented 5 years ago

in the source code you describe a different compile error. Which one is the correct one? Does it change results?

EoghanTotten commented 5 years ago

Hi @sstaehler , I think my comments in source code are just sloppy language: it is the same compile WARNING, rather than error but seemed to change results in a positive manner.