Closed d-chambers closed 3 years ago
After this gets merged we should probably setup some CI as well. GH actions is easy enough to implement there really is no excuse for not doing it...
Note: we also need to change the calc_energy
to sum the components and not take their norms but I don't have time to do it right now.
Changes were merged via #16
This PR is based on #16 but does some refactoring to address most of the review points. It also adds a
NodePipline
class as a "higher-level" interface to get source parameters using sensible defaults for node datasets.@sboltz mind taking a look at this? Mainly the Pipeline, spectrumgroup and associated tests.