Closed fraga closed 11 years ago
I guess this is really important. Leveraging your question... As I don't know all about core business, so I also guess important create issues to mark what is necessary to do, assign to someone and add it to milestone.
Github offer it to us, so why don't we use it?
Other point, we should use Pull Requests to solve issues opened. As I'm doing. Ok, these are some suggestions. :relaxed:
Milestones gives direction, that's what we need. Milestones on github are referenced to issues, pretty easy to manage. We could create v0.8 milestone for instance...
Yes, we should use pull requests. Normally you would fork the repo, set it up as a remote "upstream" for instance and you commit on your own github repo then you send pull requeests.
@fraga it's not necessary fork the original repository. You're a committer in this project, so you can do what I'm doing: creating a new branch based on master (always) with some code that solves any issue, create tests for it and after all tests are green, submit a pull request. It's simple. If you don't know how can you do that, I can show how this works.
I agree with you about milestones. I don't know what is the next step, so I'm doing a few improvements and creating some tests to turn our development environment better. However, it's important knows what is the expectation of the client and milestones can do it for us.
@fabianoalmeida thanks, it's just because I don't feel safe when working on same repo, I prefer the old fork pull style =) But if the rule is to commit here I can follow rules
@seixasfelipe should we give some directions by creating milestones?
@fraga don't worry, git is safe! We can work on the project relaxed, if someone does mess we can revert the commit like a charm. As I said, don't worry and happy committing. :smile:
On Monday, March 4, 2013, Rodrigo Fraga wrote:
@fabianoalmeida https://github.com/fabianoalmeida thanks, it's just because I don't feel safe when working on same repo, I prefer the old fork pull style =) But if the rule is to commit here I can follow rules
@seixasfelipe https://github.com/seixasfelipe should we give some directions by creating milestones?
— Reply to this email directly or view it on GitHubhttps://github.com/seixasfelipe/cleaners-panamby/issues/12#issuecomment-14405764 .
Fabiano Almeida http://about.me/fabianoalmeida
Yeah guys, you are right, we need some milestones! I'm little bit busy now, specially this week that I've started my Intensive French classes, so I'm currently spending some time trying to adapt myself with classes and transportation schedules, therefore I'm so much offline in comparison with last week and so on =D
I'm doing my best and I'll start to write down some directions, as well as, I'll try to talk with our most possible client/customer if we will do it for real or just to learn and have fun lol...
By the way, we must always have pretty working interface/code in master branch to deploy into production environment to avoid our client/customer see some bugs.. Nevertheless, I'll try to give you the POWER (Mmuuuhahahahah <-- devil's laugh) to deploy into production env =)
@fraga IMO you can do your commit the way your are most used to do it. So if you prefer to fork, write some code and then send a Pull Request, that's fine! But if you want to do as @fabianoalmeida pointed, create a new branch, write some code and send a Pull Request, that's also fine! =D
@seixasfelipe @fabianoalmeida perfect! We have a milestone, I'm closing this!
Are we going to have milestones?