search

seixasfelipe / cleaners

Cleaners - Management Application
MIT License
2 stars 0 forks source link

Fixing failing tests #43

Closed fraga closed 11 years ago

fraga commented 11 years ago

all tests passes now

fabianoalmeida commented 11 years ago

If this PR fix the failing tests, I can merge it. By the way, we'll refactor some things. :blush:

fabianoalmeida commented 11 years ago

@fraga I'm seeing the create orders migration file and I thought that this line:

t.boolean :closed, null: false, default: false

Could be something like that:

t.datetime :closed_at

Using this way we get know when this order was closed (date and hour). What do you think?

fraga commented 11 years ago

Can an order be closed and reopened and closed again?

fabianoalmeida commented 11 years ago

I think that an order just can be closed after the customer pay for all services which was made in his car. After created an order, this one can be closed or canceled; closed after paid and canceled by some reason. These are my opinions.

fraga commented 11 years ago

Well, I think we can add this field no problem

fabianoalmeida commented 11 years ago

@fraga Did you fix it? Can I merge now?

fraga commented 11 years ago

So I'm lost now with this PR =) let me revise it