Fix Issue #854 - Range slider, min value over max value.

[jespirit]

Pull Requests

Please accompany all pull requests with the following (where appropriate):

• [x] unit tests (we use Jasmine 2.x.x)
• [x] JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
• [x] Link to original Github issue (if this is a bug-fix)
• [ ] documentation updates to README file
• [ ] examples within /tpl/index.tpl (for new options being added)
• [ ] Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

This pull request fixes https://github.com/seiyria/bootstrap-slider/issues/854. You can check the issue for my JSFiddle that is used to reproduce the bug.

I added 2 unit tests as well as making a minor edit with a unit test in the same file: test/specs/DraggingHandlesSpec.js.

I will say that I was getting this error Fatal error: Callback must be a function displayed at the very end in red text, after running the unit tests using grunt test command. I don't know why, thoughts?

[seiyria]

The code here looks good. You'll have to figure out how to make codeclimate happy with your tests.

@rovolution do you know what's up with the grunt error?

[rovolution]

@seiyria personally, im not too picky about fixing the code climate issue, and have debated just removing it altogether since i feel it doesnt deliver any real value TBH.

[seiyria]

@rovolution That's fine with me. I'd rather replace it with a linter if we had that set up or some-such. Or just not have it altogether.

[rovolution]

we already have a linter setup in our CI check - https://github.com/seiyria/bootstrap-slider/blob/master/Gruntfile.js#L274-L278

[rovolution]

@jespirit LGTM 👍 ill merge, publish, and update changelog.

[rovolution]

@jespirit merged and published to v10.2.3.

Thanks again for your contribution!