seiyria / bootstrap-slider

A slider control for Bootstrap 3 & 4.

http://seiyria.github.io/bootstrap-slider/

Other

3k stars 1.14k forks source link

Remove extra calls that are unnecessary #880

Closed jespirit closed 5 years ago

jespirit commented 5 years ago

I wrote unit tests for checking if _setDataVal() works properly.

It's going to be a bit more difficult to write tests to check if removing the calls to _layout() haven't broken anything.

Pull Requests

Please accompany all pull requests with the following (where appropriate):

[ ] unit tests (we use Jasmine 2.x.x)
[ ] JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
[ ] Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

jespirit commented 5 years ago

Good to know.

Actually, I never meant to call that function. Thanks for the reviews.