pimlie commented 5 years ago

Pull Requests

Please accompany all pull requests with the following (where appropriate):

[ ] unit tests (we use Jasmine 2.x.x)
[ ] JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
[ ] Link to original Github issue (if this is a bug-fix)
[ ] documentation updates to README file
[ ] examples within /tpl/index.tpl (for new options being added)
[ ] Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

PR #879 / v10.3.4 introduced an issue for range sliders as a change event was only triggered when both lower and upper value changed. See https://github.com/pimlie/vue-bootstrap-slider/issues/11 for downstream issue. This PR fixes that.

u01jmg3 commented 5 years ago

Correction: it was PR #879 (8b5ad4d)

viceice commented 5 years ago

fixes #898 too 👍

jespirit commented 5 years ago

I'm on it. Let me just add a unit test. Was my fault.

seiyria / bootstrap-slider

fix: trigger change on either range value #897

Pull Requests