search

seiyria / bootstrap-slider

A slider control for Bootstrap 3 & 4.
http://seiyria.github.io/bootstrap-slider/
Other
3k stars 1.14k forks source link

Wrong change detection for range change event #898

Closed viceice closed 5 years ago

viceice commented 5 years ago

Wrong change detection on line 962:

https://github.com/seiyria/bootstrap-slider/blob/d41fa60264f5177a9c4e646b8a8a641b44e1cda2/src/js/bootstrap-slider.js#L960-L973

&& should be ||, otherwise hasChanged is always false if only one value has changed.

I can send a PR if required.

viceice commented 5 years ago

This was introduces with by PR #879

viceice commented 5 years ago

And is related to #878

u01jmg3 commented 5 years ago

Duplicate - see #897

viceice commented 5 years ago

Ups, #897 was opened a few minutes before mine :joy:

jespirit commented 5 years ago

Wow, just a few minutes apart.