viceice commented 5 years ago

Pull Requests

Please accompany all pull requests with the following (where appropriate):

[x] unit tests (we use Jasmine 2.x.x)
[ ] JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
[x] Link to original Github issue (if this is a bug-fix)
[ ] documentation updates to README file
[ ] examples within /tpl/index.tpl (for new options being added)
[x] Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

This fixes #896

viceice commented 5 years ago

I only needed 5 min to fix the code, but i spend 3 hours to make a good test. :stuck_out_tongue_closed_eyes:

jespirit commented 5 years ago

I only needed 5 min to fix the code, but i spend 3 hours to make a good test.

Haha, I know exactly what you mean.

Great work, will be merging soon.

seiyria / bootstrap-slider