seiyria / bootstrap-slider

A slider control for Bootstrap 3 & 4.
http://seiyria.github.io/bootstrap-slider/
Other
3k stars 1.14k forks source link

10.5.0 [Error] Unable to preventDefault inside passive event listener invocation. #906

Closed Fenny closed 4 years ago

Fenny commented 5 years ago

Issues

NOTE: Before filing a new issue, please search through the open issues list and check to see if an existing issue already exists that describes your problem. If so, leave a comment within that issue with the checklist items described below.

Please make sure you include the following in your issue report where appropriate:

bootstrap-slider.js:1501 Unable to preventDefault inside passive event listener invocation.

Does this has to do with the tooltip touch mobile fix?

jespirit commented 5 years ago

Does this has to do with the tooltip touch mobile fix?

Yes. Making a touch event listener passive notifies the browser that the event listener will not prevent the default action of scrolling the page and therefore improve performance by allowing the browser to scroll the page without waiting for event listener to complete.

This will be fixed in this pull request https://github.com/seiyria/bootstrap-slider/pull/899

You can read more about it here: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Improving_scrolling_performance_with_passive_listeners

Fenny commented 5 years ago

Thanks, but that pull request was 15 days ago :(