search

seiyria / bootstrap-slider

A slider control for Bootstrap 3 & 4.
http://seiyria.github.io/bootstrap-slider/
Other
3k stars 1.14k forks source link

Cannot read property 'removeChild' of null #911

Open viceice opened 5 years ago

viceice commented 5 years ago

If i destroy a slider, who's parent node has been removed from the dom, it will crash here:

https://github.com/seiyria/bootstrap-slider/blob/4bac28fdfad8232c8f34bdd13ebda355864b78a0/src/js/bootstrap-slider.js#L1002

viceice commented 5 years ago

I'm calling destroy from ko.utils.domNodeDisposal.addDisposeCallback callback.

seiyria commented 5 years ago

You'll need to provide a demo. But also I'm not sure this happens with any of the other libraries we list so if this is exclusive to knockout then it might just be a knockout problem.

viceice commented 5 years ago

Ok, i will try to build a fiddle. My current workaround is to use JQuery.empty to cleanup.