search

seiyria / bootstrap-slider

A slider control for Bootstrap 3 & 4.
http://seiyria.github.io/bootstrap-slider/
Other
3k stars 1.14k forks source link

jQuery dependency - possible regression? #941

Open orszaczky opened 4 years ago

orszaczky commented 4 years ago

Looks like PR #580 has been merged, and yet the update is not in the codebase: https://github.com/seiyria/bootstrap-slider/commit/649128f401c9b1aa301faf10486d89d5ad8ab688

https://github.com/seiyria/bootstrap-slider/issues/578#issuecomment-626176829

mistic100 commented 2 years ago

For some reason it was reverted https://github.com/seiyria/bootstrap-slider/commit/3ce5454da171636f640ddbe8d3d481a225efbbf2

Personnally I use a Webpack alias to remove jquery dependency:

{
  resolve: {
    alias: {
      jquery: `${__dirname}/includes/jquery-stub.js`,
    }
  }
}
// jquery-stub.js
module.exports = null;
mistic100 commented 2 years ago

found the reason here https://github.com/seiyria/bootstrap-slider/issues/589#issuecomment-229232517