search

seiyria / ng2-ace

A basic ace editor directive for angular 2.
MIT License
31 stars 128 forks source link

Missing typescript definitions #1

Open rombrom opened 8 years ago

rombrom commented 8 years ago

Hi! Could there be a possibility of adding typescript definitions so the ng2-ace module plays nicely with Angular2/Typescript? Thanks!

seiyria commented 8 years ago

If you PR them, I'll take it. I don't use typescript and have no interest in it at this point in time.

cyberbeast commented 8 years ago

Would really appreciate the addition of the typescript definitions. :)

seiyria commented 8 years ago

+1s are just noise. As I said I have no interest in it, so if you want it you will need to pr it to me.

jLouzado commented 8 years ago

I'd like to work on this; quite need this plugin for a project I'm working on. Does that mean that I'd have to port the entire project over to Typescript to then write the typings? Any nudge in the right direction would be greatly appreciated...

seiyria commented 8 years ago

I'm pretty sure you just need to make a .ts.d file that matches the projects API. I'm not sure what you need to do past that, though.

sinedied commented 8 years ago

In the meantime, any idea how to make this work with an angular2/typescript project generated by angular-cli?

When writing this import { AceEditorDirective } from 'ng2-ace'; I have an error:

Cannot find module 'ng2-ace'.