Patch for vala 0.7.4 with problem

[GoogleCodeExporter]

I tried to do some vtg changes to compile with vala 0.7.4 (see patch).
There is a remaining issue with the generated c code in bracketcompletion.
Please check it. Maybe it is a vala bug?

Original issue reported on code.google.com by shuerhaaken on 29 Jun 2009 at 5:24

Attachments:

• vtg-vala74.patch

[GoogleCodeExporter]

Thanks for you patch. 

About the problem in the bracket completion source, yes it's a vala bug, I 
already
sent a test case and a little patch to the vala ML.

Original comment by seje...@gmail.com on 30 Jun 2009 at 10:24

• Changed state: Accepted
• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Thanks for accepting my patch! 
Unfortunately the problem remains for me. If it was a vala bug, what was the 
fix? I
checked vala repository and there was no new commit in the last 48 hours.

Original comment by shuerhaaken on 2 Jul 2009 at 11:09

[GoogleCodeExporter]

I still have the c compiler errors.

vtgbracketcompletion.c: In function 'vtg_bracket_completion_get_type':
vtgbracketcompletion.c:604: error: 'vtg_bracket_completion_type_id' undeclared 
(first
use in this function)
vtgbracketcompletion.c:604: error: (Each undeclared identifier is reported only 
once
vtgbracketcompletion.c:604: error: for each function it appears in.)
vtgbracketcompletion.c: In function 'vtg_bracket_completion_register_type':
vtgbracketcompletion.c:610: error: 'vtg_bracket_completion_type_id' undeclared 
(first
use in this function)
make[4]: *** [vtgbracketcompletion.lo] Error 1
make[4]: Leaving directory `/home/qnull/Desktop/vtg-read-only/vtg'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/qnull/Desktop/vtg-read-only/vtg'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/qnull/Desktop/vtg-read-only/vtg'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/qnull/Desktop/vtg-read-only'
make: *** [all] Error 2

Original comment by shuerhaaken on 3 Jul 2009 at 7:51

[GoogleCodeExporter]

Yes the bug isn't fixed yet.

See: http://article.gmane.org/gmane.comp.programming.vala/3609

And: http://bugzilla.gnome.org/show_bug.cgi?id=587444

Meanwhile you can compile vala with the patch supplied in the Bug Report.

Original comment by seje...@gmail.com on 3 Jul 2009 at 9:00

• Changed state: Accepted

[GoogleCodeExporter]

Ok. Thanks! I used this patch for the git version of vala and now vtg compiles 
again.

Original comment by shuerhaaken on 3 Jul 2009 at 5:18

[GoogleCodeExporter]

A fix by Jurg is landed on vala master today!

Original comment by seje...@gmail.com on 8 Jul 2009 at 9:06

• Changed state: Fixed

[GoogleCodeExporter]

Issue 81 has been merged into this issue.

Original comment by seje...@gmail.com on 29 Aug 2009 at 4:06

[GoogleCodeExporter]

Original comment by seje...@gmail.com on 22 Sep 2009 at 6:57

• Changed state: Released
• Added labels: Release0.5.0

[GoogleCodeExporter]

Original comment by seje...@gmail.com on 22 Sep 2009 at 7:00

• Added labels: Milestone-Release0.5.0

[GoogleCodeExporter]

Original comment by seje...@gmail.com on 22 Sep 2009 at 7:01

• Removed labels: Release0.5.0