search

sek-consulting / solid-ui

Beautifully designed components. Built with Kobalte & corvu. Styled with Tailwind CSS.
https://www.solid-ui.com
MIT License
674 stars 25 forks source link

Input component is missing #104

Closed TheKnightCoder closed 3 weeks ago

TheKnightCoder commented 3 weeks ago

Input component has disappeared in master

CorentinTh commented 3 weeks ago

Hi @TheKnightCoder I think it has just become Text Field

TheKnightCoder commented 3 weeks ago

Hi @TheKnightCoder I think it has just become Text Field

ty, whats the reason for the change? the Input seemed much simpler to use

sek-consulting commented 3 weeks ago

Sorry for the inconvenience.

Yes I dropped it in favor of Text Field. Since Kobalte has a primitive for it I want to be as close to the source as possible while still providing the shadcn/tremor style.

Was a simple wrapper easier to use? Probably But does the Text Field primitive provide usability/accesibility benefits? Yes.

TheKnightCoder commented 3 weeks ago

Sorry for the inconvenience.

Yes I dropped it in favor of Text Field. Since Kobalte has a primitive for it I want to be as close to the source as possible while still providing the shadcn/tremor style.

Was a simple wrapper easier to use? Probably But does the Text Field primitive provide usability/accesibility benefits? Yes.

Thanks for all your work on solid-ui really appreciate it... What usability benefits does the Text field provide? so that I can make the most of it

sek-consulting commented 3 weeks ago

https://kobalte.dev/docs/core/components/text-field

Since the Description/Label/ErrorMessage Components are included you have a better visual hierarchy especially with forms without the need to add a wrapper div or empty </>. Also you you have everything set up for both input and textarea.

There might be some more but these are the most impactful ones atleast for me :)