Open daelmaak opened 4 days ago
Latest commit: a572f254b43928c03c3b42cd35e84f5f720e0d4c
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
solid-ui-components | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 30, 2024 8:57am |
If the screen gets small enough for the dialog content to overflow it, the content is not scrollable and the user has no chance to see all of it. This can easily happen on mobile with keyboard open.
The solution I chose is to limit the height to viewport height and let the browser handle the overflow by showing a scrollbar.
The 2 vids - before and after - demonstrate the change.
https://github.com/sek-consulting/solid-ui/assets/34311965/9367a0f4-df49-441f-aaa9-3543806e9caa
https://github.com/sek-consulting/solid-ui/assets/34311965/b1cc900a-f094-4a36-991a-c787fbe402e7