search

sek-consulting / solid-ui

Beautifully designed components. Built with Kobalte & corvu. Styled with Tailwind CSS.
https://www.solid-ui.com
MIT License
832 stars 32 forks source link

[Bug] Context Menu doesn't work on touch devices. #132

Closed vanillacode314 closed 2 weeks ago

vanillacode314 commented 1 month ago

repro: https://stackblitz.com/edit/github-ajatgp?file=src%2Froutes%2Findex.tsx

steps:

  1. open on mobile or desktop touch emulation
  2. long press area to open menu
  3. try to click the item and nothing happens
sek-consulting commented 2 weeks ago

I tested it with the following setups and it worked:

So I unfortunatelly can't reproduce the issue. Did you try the official docs on mobile? Cause those work flawless too an the setups above. https://www.solid-ui.com/docs/components/context-menu

vanillacode314 commented 2 weeks ago

Hmm, it seems to be working inconsistently, might be a touch target issue. closing this anyways. Thanks for looking into this :)

vanillacode314 commented 1 week ago

anyone looking at this in the future. The issue was happening because I was using onClick instead of onSelect on the DropdownItem