sek-consulting / solid-ui

Beautifully designed components. Built with Kobalte & corvu. Styled with Tailwind CSS.
https://www.solid-ui.com
MIT License
680 stars 25 forks source link

Fix/Add missing animations to Dialog and Popover #39

Closed daugvinasr closed 7 months ago

daugvinasr commented 7 months ago

As Kobalte exposes expanded and closed data attributes we can use them to wire up animations that would follow ones on shadcn/ui

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-ui-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 4:13pm
changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: 8b4702043cf9f369722ccea842704888733f39d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sek-consulting commented 7 months ago

Thanks for contributing!