search

sek-consulting / solid-ui

Beautifully designed components. Built with Kobalte & corvu. Styled with Tailwind CSS.
https://www.solid-ui.com
MIT License
680 stars 25 forks source link

Use JSON5 for parsing tsconfig #59

Closed iAverages closed 5 months ago

iAverages commented 5 months ago

This PR replaces JSON.parse, with JSON5.parse using the JSON5 package.

tsconfig uses JSON5 which allows for comments as well as some trailing commas. Prettier, by default, adds trailing commas to tsconfig which causes this cli to break.

Replacing JSON with JSON5 parse fixes the comment issues and makes using the CLI more reliable.

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 84bde37f284ef0e396c1b3609d890e78411be7ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-ui-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 7:22pm
sek-consulting commented 5 months ago

Thanks for the contribution :) Since I'm in the process of updating the cli anyway this is a welcome addition.